I wrote a blog post last week and bits of it were wrong. This is not a retraction of that blog post, I just wanted to share the feedback that I got, the things I changed and some lessons that I learned.
- Code styles between my two examples were different
- Two semicolons were missing
- It was better to format chains of Promises by placing the
.thenon the following line and indenting
I knew that the style of the two snippets was different as one had been written a year ago for the 12 Devs of Christmas blog and I had opted to retain the original code. But, mixing code styles in a project is unforgivable so why should a blog post be any different?
Over promising under delivers
The second piece of feedback came over Twitter, firstly in a direct message from Masse Fierro and then in a mention from James DiGioia. I’d gotten paranoid with my Promises and written one or two too many. I just needed to return the final data and not resolve another Promise.
const punkAPIPromise = fetch(punkAPIUrl) .then(res => res.json()) - .then(data => Promise.resolve(data)); + .then(data => data);
Thanks to Masse and James I fixed that too.
The last thing to be pointed out, and probably the most important, was not about the content of the blog post but the accessibility of my site in general. James Spencer pointed out that my site failed colour contrast tests for both the code samples and links on the site. The tests they referred to are the Web Content Accessibility Guidelines on colour contrast which recommend a contrast ratio of at least 4.5:1 for regular body text. I learned some interesting things trying to fix this:
- tota11y, by the Khan Academy, is a really awesome tool
- I learned about it from the link James shared with me
- It suggests colours that are similar to the existing colour that would pass the test
- It also has other plugins that visualise things like out of order heading usage, poor link text, missing alt attributes and a few more, helping you to ensure your site is as accessible as possible
- Syntax highlighting themes are really bad at accessible contrast levels
- I was using a version of Solarized Dark which failed in a number of places
- I couldn’t find any syntax highlighting theme that had decent contrast for all elements out of the box
- Using syntax highlighting in your editor is one thing, you can use whichever contrast levels you are comfortable with, but on the web anyone could be reading it
Eventually I chose to use the suggestions from tota11y to fix the four colours in Solarized Dark that were too low contrast. I also fixed my link text colour.
I was a little embarrassed about this because, as I said in a tweet, I thought I used to be good at this sort of thing. So much so that almost 10 years ago I wrote a blog post on the very matter of colour in web accessibility. This just goes to show that not only do we learn new things every day in web development, retaining old things is just as important.
Always be improving
I want to thank Masse, the two Jameses and the now mystery Redditor for giving me the feedback that helped to improve both my blog post and my site. If you see anything on this site that could be improved I welcome the feedback. I learned that I should keep my eye on the formatting and consistency of my code, not to over promise and to pay closer attention to accessibility concerns.
Overall I learned that in order to always be improving—my code, my site, myself—sometimes I need to do things wrong.